-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telegram, initial language setup (for future changes in frontend), don't remove last buy when under amount, reworked notifications. #204
Conversation
Right now it has: -Telegram notifications; -Don't remove last buy when under X amount (minimum 1); -Reworked notifications to be readable in telegram and slack. -I've added a language switch to receive the updates in one of the two current languages (enUS and ptBR). -It should spam less checking buy. To setup telegram, you just need to edit .env file and fill the form. The bot you can create talking with @Botfather in telegram and he will tell the steps to do. The chat_ID you can get by talking with @userinfobot. Thanks. I'll open a push request.
Hey, Thanks for your contributions. This is pretty good. It looks like you try to cover two features: Again that is awesome, thanks for that. However, I see some issues with your PR. General:
Remove the last buy price when it is under configured amount:
Improve notificaitons:
I appreciate your effort for the PR, let's continue to discuss. |
Of course! Sorry for that. It was the replace all fault. I needed to replace every 'slack' reference and then it changed even the .test files. I will separate them.
Sure! I didn't think about that. I thought the symbols would save the last amount when we changed. But they don't. I will do that!
And if the bot send the debug message as a .txt file through telegram (don't know if slack support it) ? It would be readable and we can even open the file to see what gone wrong.
Kkk, sorry for the messager 😞. I will rename it. It was my fault.
I will study apprise to implement it. Thanks for the head's up.
Oh. Again, didn't tought about that. Sure I will implement the notification options!
I'm very happy to help. Thanks, again and sorry for the newbie mistakes. ❤️ |
No problem. Please don't be sorry. It's always welcome to get any contributions. :) FYI, I just edited my last message. Just in case you missed.
|
Sorry, didn't know that. I will fix it asap. Didn't know the test files was useful. Now I know. Sorry. They are giving failure because I didn't fix the slack replace in them. |
Yeah, writing tests are a horrible experience, but if I also find lots of my mistakes by writing the tests. |
@pedrohusky Btw, for the language code, please follow ISO language code - https://www.andiamo.co.uk/resources/iso-language-codes/ |
@chrisleekr sure! I'm making some changes right now. :) |
Edited the .test files to their original state. Messager is now messenger. Last buy threshold now is like max purchase amount, thanks @chrisleekr
417fe24
to
b7b7260
Compare
Hi! I've made the last buy threshold work like max purchase amount, the language now follows the ISO standard. How to work with test files? I only get this:
Don't know what to do. I still don't know how what to do with apprise, will look more into it. Could you please point me a direction? |
Closed in favour of #206 |
Right now it has:
-Telegram notifications;
-Don't remove last buy when under X amount (minimum 1);
-Reworked notifications to be readable in telegram and slack.
-I've added a language switch to receive the updates in one of the two current languages (enUS and ptBR).
-It should spam less checking buy.
SETUP TELEGRAM:
To setup telegram, you just need to edit .env file and fill the form. The bot you can create talking with @Botfather in telegram and he will tell the steps to do.
The chat_ID you can get by talking with @userinfobot.
Motivation and Context
Those changes was required by a lot of people in discord and telegram. It solves the problem that the bot would loose its last price, the coin drops and the bot buys more. Then it sells every coin bought at the last coin bough profit.
Telegram is necessary, not everyone uses slack.
I've reworked the messages to be more readable for the user. It is a work in progress. It will be polished later.
Multilanguage is very appreciated by everyone. :)
How Has This Been Tested?
I've tested the notifications from telegram, the last buy price is working 100% (the bot removes when it sell successfully), and the notification language too.
Screenshots (if appropriate):
-- This is using the ptBR language!